baohe-zhang commented on a change in pull request #29509:
URL: https://github.com/apache/spark/pull/29509#discussion_r475320679
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -1214,8 +1214,8 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
// Use InMemoryStore to rebuild app store
while (hybridStore == null) {
// A RuntimeException will be thrown if the heap memory is not sufficient
- memoryManager.lease(appId, attempt.info.attemptId, reader.totalSize,
Review comment:
It's related to the test code, but my original thought is that passing
the actual amount of memory, instead of filesize to memoryManager.lease() would
make more sense. Although exposing inner details to fsHistoryProvider is not
ideal. What's your opinion? Should I revert this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
