Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5227#discussion_r27640645
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java ---
@@ -260,15 +260,14 @@ static String quoteForBatchScript(String arg) {
quoted.append('"');
break;
- case '=':
- quoted.append('^');
- break;
-
default:
break;
}
quoted.appendCodePoint(cp);
}
+ if (arg.codePointAt(arg.length() - 1) == '\\') {
+ quoted.append("\\");
--- End diff --
This is indented too far. Why would a backslash need escaping only in the
final position?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
