GitHub user mengxr opened a pull request:
https://github.com/apache/spark/pull/5431
[WIP][SPARK-5957][ML] better handling of parameters
The design doc was posted on the JIRA page.
1. Use codegen for shared params.
1. Move shared params to package `ml.param.shared`.
1. Set default values in `Params` instead of in `Param`.
1. Add a few methods to `Params` and `ParamMap`.
1. Move schema handling to `SchemaUtils` from `Params`.
- [ ] check visibility of the methods added
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mengxr/spark SPARK-5957
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5431.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5431
----
commit dcab97aa1dbf4573c3fcb379c3152bca1b0837e6
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-08T20:04:51Z
add codegen for shared params
commit abb7a3bcabe9091d5b5ad493660daaa4c671f613
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-08T20:56:08Z
update default values handling
commit 1c72579a731d61e2bbbccd00b4bc9358618a58da
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-08T21:01:31Z
pass test compile
commit d9302b82eb2c325b15f20dd1b30bdf4c7cdc58a6
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-08T21:24:31Z
generate default values
commit a9dbf59a960e1a35c0cbdadebefa65b721e73bf5
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-08T21:31:12Z
minor updates
commit 0d3fc5ba1fb0cb15bcb2bda20ebf1d98cfd48243
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-08T21:49:04Z
setDefault after param
commit eeeffe89409e7b97ad0e091e18f1084621543422
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-08T22:33:19Z
map ++ paramMap => extractValues
commit 0d9594e41d69fc74facb95d672612b22c4f5c44c
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-08T22:43:59Z
add getOrElse to ParamMap
commit 4ac6348c3211c1221d21030e13ac0f925dd81abc
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-08T23:54:42Z
move schema utils to SchemaUtils
add a few methods to Params
commit 48d0e843d8e1bb4d6db275316435829c81d628e3
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-09T00:13:56Z
add remove and update explainParams
commit 94fd98e94ebf3c4460e941ad36aab711791d107d
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-09T00:21:19Z
fix explain params
commit 29b004ca130305969f7c48285c9c17fae8f662e1
Author: Xiangrui Meng <m...@databricks.com>
Date: 2015-04-09T00:32:12Z
update ParamsSuite
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
