Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/5431#issuecomment-92509721
  
    Should this method in Params be made abstract?
    ```
    def validate(paramMap: ParamMap): Unit = {}
    ```
    I just realized we haven't been using it, and making it abstract would 
force users to think about it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to