cloud-fan commented on a change in pull request #30097:
URL: https://github.com/apache/spark/pull/30097#discussion_r511780716
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/SubstituteUnresolvedOrdinalsSuite.scala
##########
@@ -36,31 +37,40 @@ class SubstituteUnresolvedOrdinalsSuite extends
AnalysisTest {
// Tests order by ordinal, apply single rule.
val plan = testRelation2.orderBy(Literal(1).asc, Literal(2).asc)
comparePlans(
- new SubstituteUnresolvedOrdinals(conf).apply(plan),
+ SubstituteUnresolvedOrdinals.apply(plan),
testRelation2.orderBy(UnresolvedOrdinal(1).asc,
UnresolvedOrdinal(2).asc))
// Tests order by ordinal, do full analysis
checkAnalysis(plan, testRelation2.orderBy(a.asc, b.asc))
// order by ordinal can be turned off by config
+ var newPlan: LogicalPlan = null
+ withSQLConf(SQLConf.ORDER_BY_ORDINAL.key -> "false") {
Review comment:
nit:
```
withSQLConf(SQLConf.ORDER_BY_ORDINAL.key -> "false") {
comparePlans(SubstituteUnresolvedOrdinals.apply(plan), ...)
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
