cloud-fan commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r512004978
########## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/DataSourceAnalysisSuite.scala ########## @@ -35,6 +35,7 @@ class DataSourceAnalysisSuite extends SparkFunSuite with BeforeAndAfterAll { override def beforeAll(): Unit = { super.beforeAll() + SQLConf.get.unsetConf(SQLConf.CASE_SENSITIVE) Review comment: we should do it in `aferAll`, to avoid this test suite changing the global conf object. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org