Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5208#discussion_r28198853
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
    @@ -90,6 +90,13 @@ private[sql] abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
                left.statistics.sizeInBytes <= 
sqlContext.conf.autoBroadcastJoinThreshold =>
               makeBroadcastHashJoin(leftKeys, rightKeys, left, right, 
condition, joins.BuildLeft)
     
    +      // for now let's support inner join first, then add outer join
    --- End diff --
    
    Lets explictly comment that we try SortMergeJoin first, but only if the 
config is set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to