Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5208#discussion_r28198883
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
    @@ -72,6 +72,12 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] 
with Logging with Serializ
       def requiredChildDistribution: Seq[Distribution] =
         Seq.fill(children.size)(UnspecifiedDistribution)
     
    +  /** Specifies how data is ordered in each partition. */
    +  def outputOrdering: Seq[SortOrder] = Nil
    +
    +  /** Specifies sort order for each partition requirements on the input 
data for this operator. */
    +  def requiredInPartitionOrdering: Seq[Seq[SortOrder]] = 
Seq.fill(children.size)(Nil)
    --- End diff --
    
    Lets stay consistent with the naming, `requiredChildOrdering` or maybe 
`requireChildPartitionOrdering` if you think the first is unclear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to