cloud-fan commented on a change in pull request #29882:
URL: https://github.com/apache/spark/pull/29882#discussion_r513236699
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -149,9 +153,8 @@ case class Abs(child: Expression)
protected override def nullSafeEval(input: Any): Any = numeric.abs(input)
}
-abstract class BinaryArithmetic extends BinaryOperator with NullIntolerant {
-
- protected val checkOverflow = SQLConf.get.ansiEnabled
+abstract class BinaryArithmetic(failOnError: Boolean)
Review comment:
We can make it a `val` to simplify class extension:
```
abstract class BinaryArithmetic ... {
val failOnError: Boolean
}
case class Divide(..., failOnError: Boolean = ...) extends DivModLike {...}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
