Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5236#discussion_r28261212
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -1011,6 +1013,22 @@ private[spark] object Utils extends Logging {
       }
     
       /**
    +   * Convert a time parameter such as (50s, 100ms, or 250us) to 
microseconds for internal use. If
    +   * no suffix is provided, the passed number is assumed to be in ms.
    +   */
    +  def timeStringAsMs(str: String) : Long = {
    +    JavaUtils.timeStringAsMs(str)
    +  }
    +
    +  /**
    +   * Convert a time parameter such as (50s, 100ms, or 250us) to 
microseconds for internal use. If
    +   * no suffix is provided, the passed number is assumed to be in seconds.
    +   */
    +  def timeStringAsSec(str: String) : Long = {
    --- End diff --
    
    no space before `:`, here and L1019


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to