Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5236#discussion_r28261343
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -174,6 +174,35 @@ class SparkConf(loadDefaults: Boolean) extends 
Cloneable with Logging {
         getOption(key).getOrElse(defaultValue)
       }
     
    +  /** Get a time parameter as seconds; throws a NoSuchElementException if 
it's not set. If no 
    +    * suffix is provided then seconds are assumed. 
    +    */
    --- End diff --
    
    What's the difference in this context? this works as javadoc too. The 
formatting could be more like:
    ```
    /**
     * Docs...
     * @throws
     */
    ```
    but should still render OK either way?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to