Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5354#issuecomment-92512638
Yes, let's call the shaded B artifact B'. Are you saying that the published
artifact of A shades B and C? yes, then it contains B' and C' and they are
inseparable. It isn't usual to publish a shaded artifact like that unless it is
an assembly / uber jar, which is not what projects depend on when consuming via
Maven.
A would still show a dependency on B and C in the POM, at least, if it were
shaded at assembly time using something like the shade plugin.
You are saying that A shades B and C but then declares C as a direct,
separate dependency? yes, then it shows a direct dependency on C, though I
claim it already had a transitive dependency on C in Maven. We may still be
talking about different things when it comes to what is published.
But, what is A here, `tachyon-client`? I'm not sure it's relevant to what I
am getting at. If C includes `commons-beanutils`, why exclude it? and, why does
C include `hadoop-core` for example? Again, if I understand what's what here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
