Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28283689
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -325,7 +379,7 @@ class ParamMap private[ml] (private val map:
mutable.Map[Param[Any], Any]) exten
}
/**
- * Make a copy of this param map.
+ * Creates a copy of this param map.
*/
def copy: ParamMap = new ParamMap(map.clone())
--- End diff --
Do we like copy methods to use parentheses or not? I think we're not
completely consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
