dongjoon-hyun commented on a change in pull request #30379:
URL: https://github.com/apache/spark/pull/30379#discussion_r523487480
##########
File path: sql/core/benchmarks/SubExprEliminationBenchmark-results.txt
##########
@@ -7,9 +7,9 @@ OpenJDK 64-Bit Server VM 1.8.0_265-b01 on Mac OS X 10.15.6
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
from_json as subExpr: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
-------------------------------------------------------------------------------------------------------------------------
-subexpressionElimination on, codegen on 2303 2543
238 0.0 23029833.1 1.0X
-subexpressionElimination on, codegen off 23107 23520
427 0.0 231069443.3 0.1X
-subexpressionElimination off, codegen on 23363 23848
421 0.0 233634044.9 0.1X
-subexpressionElimination off, codegen off 22997 23355
438 0.0 229974135.0 0.1X
+subexpressionElimination off, codegen on 24841 25365
803 0.0 248412787.5 1.0X
+subexpressionElimination off, codegen off 25344 26205
941 0.0 253442656.5 1.0X
+subexpressionElimination on, codegen on 2883 3019
119 0.0 28833086.8 8.6X
Review comment:
Nice. It's clearly `8.6x`. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
