viirya commented on pull request #30379: URL: https://github.com/apache/spark/pull/30379#issuecomment-727285058
> @maropu That's a good point. Initially, I thought three steps. 1) we add a benchmark with the baseline first, 2) merge the #30341, 3) update this benchmark in another PR. But, your suggestion also looks good because this PR already have (3). > > > This will be merged after #30341 finished? I think we should merge this first and in #30341 we can update this benchmark? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org