luluorta commented on a change in pull request #30289:
URL: https://github.com/apache/spark/pull/30289#discussion_r530133390
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
##########
@@ -414,6 +433,8 @@ object CatalogTable {
val VIEW_QUERY_OUTPUT_PREFIX = VIEW_PREFIX + "query.out."
val VIEW_QUERY_OUTPUT_NUM_COLUMNS = VIEW_QUERY_OUTPUT_PREFIX + "numCols"
val VIEW_QUERY_OUTPUT_COLUMN_NAME_PREFIX = VIEW_QUERY_OUTPUT_PREFIX + "col."
+
+ val VIEW_QUERY_SQL_CONFIGS = VIEW_PREFIX + "query.sqlConfigs"
Review comment:
done
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1448,6 +1448,15 @@ object SQLConf {
"must be positive.")
.createWithDefault(100)
+ val APPLY_VIEW_SQL_CONFIGS =
+ buildConf("spark.sql.legacy.view.applySQLConfigs")
Review comment:
done
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -334,6 +337,21 @@ case class ShowViewsCommand(
object ViewHelper {
+ private val configPrefixBlacklist = Seq(
Review comment:
done
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -334,6 +337,21 @@ case class ShowViewsCommand(
object ViewHelper {
+ private val configPrefixBlacklist = Seq(
+ SQLConf.MAX_NESTED_VIEW_DEPTH.key,
+ "spark.sql.optimizer.",
+ "spark.sql.codegen.",
+ "spark.sql.execution.",
+ "spark.sql.shuffle.",
+ "spark.sql.adaptive.")
+
+ private def isConfigBlacklisted(key: String): Boolean = {
Review comment:
done
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -380,16 +425,19 @@ object ViewHelper {
// for createViewCommand queryOutput may be different from fieldNames
val queryOutput = analyzedPlan.schema.fieldNames
+ val conf = SQLConf.get
Review comment:
done
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -361,11 +379,38 @@ object ViewHelper {
}
}
+ /**
+ * Convert the view query SQL configs in `properties`.
+ */
+ private def generateQuerySQLConfigs(conf: SQLConf): Map[String, String] = {
Review comment:
done
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -754,4 +754,77 @@ abstract class SQLViewSuite extends QueryTest with
SQLTestUtils {
}
}
}
+
+ test("SPARK-33141: view should be parsed and analyzed with configs set when
creating") {
+ withTable("t33141") {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
