luluorta commented on a change in pull request #30289:
URL: https://github.com/apache/spark/pull/30289#discussion_r530134316
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -361,11 +379,38 @@ object ViewHelper {
}
}
+ /**
+ * Convert the view query SQL configs in `properties`.
+ */
+ private def generateQuerySQLConfigs(conf: SQLConf): Map[String, String] = {
+ val modifiedConfs = conf.getAllConfs.filter { case (k, _) =>
+ conf.isModifiable(k) && !isConfigBlacklisted(k)
+ }
+ val props = new mutable.HashMap[String, String]
+ if (modifiedConfs.nonEmpty) {
+ val confJson = compact(render(JsonProtocol.mapToJson(modifiedConfs)))
+ props.put(VIEW_QUERY_SQL_CONFIGS, confJson)
Review comment:
Thanks for pointing this out. Splitting a large value string into small
chunks seems a hive specific solution, so I changed to store one config per
table property entry, each with a "view.sqlConfig." prefix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
