cloud-fan commented on a change in pull request #30403:
URL: https://github.com/apache/spark/pull/30403#discussion_r530337419
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -442,19 +442,11 @@ class ResolveSessionCatalog(
ShowCreateTableCommand(ident.asTableIdentifier)
}
- case CacheTableStatement(tbl, plan, isLazy, options) =>
- val name = if (plan.isDefined) {
- // CACHE TABLE ... AS SELECT creates a temp view with the input query.
- // Temp view doesn't belong to any catalog and we shouldn't resolve
catalog in the name.
- tbl
- } else {
- parseTempViewOrV1Table(tbl, "CACHE TABLE")
- }
- CacheTableCommand(name.asTableIdentifier, plan, isLazy, options)
+ case CacheTable(multipartIdent, plan, isLazy, options) =>
+ CacheTableCommand(multipartIdent, plan, isLazy, options)
Review comment:
it seems unnecessary to have `CacheTable` now. Should the parser create
`CacheTableCommand` directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
