viirya commented on a change in pull request #30492:
URL: https://github.com/apache/spark/pull/30492#discussion_r530820010
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala
##########
@@ -114,6 +115,8 @@ private[storage] class BlockManagerDecommissioner(
// driver a no longer referenced RDD with shuffle files.
if
(bm.migratableResolver.getMigrationBlocks(shuffleBlockInfo).isEmpty) {
logWarning(s"Skipping block ${shuffleBlockInfo}, block
deleted.")
+ } else if (fallbackStorage.isDefined) {
+ fallbackStorage.foreach(_.copy(shuffleBlockInfo, bm))
Review comment:
When is the best time to move block to fallback storage during
decommission? For current change, it just chooses fallback storage once
encountering failure at first try.
Should we let retrying do the work until reaching
`maxReplicationFailuresForDecommission` and then move to fallback storage?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
