viirya commented on a change in pull request #30492:
URL: https://github.com/apache/spark/pull/30492#discussion_r531174946
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -627,7 +627,16 @@ private[spark] class BlockManager(
override def getLocalBlockData(blockId: BlockId): ManagedBuffer = {
if (blockId.isShuffle) {
logDebug(s"Getting local shuffle block ${blockId}")
- shuffleManager.shuffleBlockResolver.getBlockData(blockId)
+ try {
+ shuffleManager.shuffleBlockResolver.getBlockData(blockId)
+ } catch {
+ case e: IOException =>
+ if
(conf.get(config.STORAGE_DECOMMISSION_FALLBACK_STORAGE_PATH).isDefined) {
+ FallbackStorage.read(conf, blockId)
+ } else {
+ throw e
+ }
Review comment:
Can you explain the reasoning here? So once any executor cannot get
local shuffle block, it will always try to read from fallback storage?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
