Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r28728653
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -122,7 +126,7 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
             } else {
               logInfo("Registered executor: " + executorRef + " with ID " + 
executorId)
               context.reply(RegisteredExecutor)
    -
    +          latestTokens.foreach(x => context.reply(NewTokens(x)))
    --- End diff --
    
    I actually tried doing that, but it failed a huge number of tests and 
thought it was perhaps not worth that risk. 
    
    With the new RPC thing, I was not sure if calling send from inside this 
method would break something somewhere. Really, yes, it is `send` we want to 
call here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to