Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r28729380
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -122,7 +126,7 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
             } else {
               logInfo("Registered executor: " + executorRef + " with ID " + 
executorId)
               context.reply(RegisteredExecutor)
    -
    +          latestTokens.foreach(x => context.reply(NewTokens(x)))
    --- End diff --
    
    My concern with `send` (or with your current `reply`) is that the sender 
doesn't know if it arrived. So you could have `RegisteredExecutor` arrive but 
`NewTokens` not arrive. My hope is that in that case the connection would be 
terminated and the executor would go away (instead of staying up in a broken 
state), but with akka, I have no idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to