Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5626#discussion_r28987617
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/impl/tree/treeParams.scala ---
    @@ -298,3 +302,200 @@ private[ml] object TreeRegressorParams {
       // These options should be lowercase.
       val supportedImpurities: Array[String] = 
Array("variance").map(_.toLowerCase)
     }
    +
    +/**
    + * :: DeveloperApi ::
    + * Parameters for Decision Tree-based ensemble algorithms.
    + *
    + * Note: Marked as private and DeveloperApi since this may be made public 
in the future.
    + */
    +@DeveloperApi
    +private[ml] trait TreeEnsembleParams extends DecisionTreeParams {
    +
    +  /**
    +   * Fraction of the training data used for learning each decision tree.
    +   * (default = 1.0)
    +   * @group param
    +   */
    +  final val subsamplingRate: DoubleParam = new DoubleParam(this, 
"subsamplingRate",
    +    "Fraction of the training data used for learning each decision tree.")
    +
    +  /**
    +   * Random seed for bootstrapping and choosing feature subsets.
    +   * @group param
    +   */
    +  final val seed: LongParam = new LongParam(this, "seed",
    --- End diff --
    
    This should go to shared params.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to