Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5626#issuecomment-95675400
@jkbradley I made one pass on the public APIs. There are some issues from
the ml.DT PR:
1. Node.prediction should say "leaf" node instead of "internal":
https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala#L33
2. CategoricalSplit.getLeftCategories. Maybe this should be a property
since it is immutable. No strong preference. Btw, I'm thinking about using
`BitSet` to store left category indices to save storage.
We can address those in a separate PR. I will take another pass on the
implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
