cloud-fan commented on a change in pull request #30363: URL: https://github.com/apache/spark/pull/30363#discussion_r568391121
########## File path: core/src/main/scala/org/apache/spark/util/SparkConfRegisterLoader.scala ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.util + +import java.net.URL + +import scala.collection.JavaConverters._ +import scala.io.Source +import scala.reflect.runtime.{universe => ru} +import scala.util.control.NonFatal + +import org.apache.spark.internal.Logging + +object SparkConfRegisterLoader extends Logging { Review comment: Yea it's easier to just list all the known config objects, but I agree with @linhongliu-db that some modules are optional and we should only load the objects from modules when the modules are loaded. FYI all modules under the `external` directory are not loaded by default, and if they start to define configs, we will need this framework. It's also true that other spark vendors may define their own configs. This is similar to the data source registry resource files, so I don't have a big concern here as this is not the first time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
