cloud-fan commented on a change in pull request #30363: URL: https://github.com/apache/spark/pull/30363#discussion_r569131298
########## File path: core/src/main/scala/org/apache/spark/util/SparkConfRegisterLoader.scala ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.util + +import java.net.URL + +import scala.collection.JavaConverters._ +import scala.io.Source +import scala.reflect.runtime.{universe => ru} +import scala.util.control.NonFatal + +import org.apache.spark.internal.Logging + +object SparkConfRegisterLoader extends Logging { Review comment: This allows people to define SQL configs outside of Spark, e.g. spark packages, vendor-specific configs. We should probably make it clear in the PR title and description. If we just want to fix the bug, we can hardcode the loading of `HiveUtis` class like @HyukjinKwon mentioned. How about we separate this PR into 2: 1. One PR to add `SparkConfRegisterLoader`, which can be used in SetCommand and `PythonSQLUtils`. This fixes the bug for SetCommand 2. One PR to add the resource file loading, which allows people to define SQL configs outside of Spark. We can discuss more if this feature is reasonable in that PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
