Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2342#discussion_r29006547
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -17,17 +17,172 @@
package org.apache.spark.ui.jobs
-import scala.xml.{Node, NodeSeq}
+import scala.collection.mutable.{HashMap, ListBuffer}
+import scala.xml.{Node, NodeSeq, Unparsed}
+import java.util.Date
import javax.servlet.http.HttpServletRequest
-import org.apache.spark.ui.{WebUIPage, UIUtils}
-import org.apache.spark.ui.jobs.UIData.JobUIData
+import org.apache.spark.ui.{UIUtils, WebUIPage}
+import org.apache.spark.ui.jobs.UIData.{ExecutorUIData, JobUIData}
+import org.apache.spark.JobExecutionStatus
/** Page showing list of all ongoing and recently finished jobs */
private[ui] class AllJobsPage(parent: JobsTab) extends WebUIPage("") {
- private val startTime: Option[Long] = parent.sc.map(_.startTime)
- private val listener = parent.listener
+ private val JOBS_LEGEND =
+ <div class="legend-area"><svg width="200px" height="85px">
--- End diff --
I found there is a lot of extra whitespace here. Can we do the following?
1. set `#application-timeline div.legend-area { margin-top 5px; }`
2. Make these much closer vertically (y = 5, y = 30, y = 55) for the boxes.
3. Just say "Succeeded" instead of "Succeeded Job".
4. Can the bounding box be made smaller? Maybe 150px instead of 200?
If you could do the same for all the legends, that would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
