c21 commented on a change in pull request #31413:
URL: https://github.com/apache/spark/pull/31413#discussion_r569932056
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala
##########
@@ -148,19 +151,53 @@ abstract class BucketedReadSuite extends QueryTest with
SQLTestUtils with Adapti
if (invalidBuckets.nonEmpty) {
fail(s"Buckets ${invalidBuckets.mkString(",")} should have been
pruned from:\n$plan")
}
+
+ withSQLConf(SQLConf.BUCKETING_ENABLED.key -> "false") {
+ // Bucket pruning should still work when bucketing is disabled
Review comment:
@cloud-fan - always applied. I can add one if this makes surprise to
existing users/queries, and they can turn off if needed. e.g.
`spark.sql.sources.bucketing.pruning.enabled`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
