c21 commented on a change in pull request #31413:
URL: https://github.com/apache/spark/pull/31413#discussion_r569966677
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -591,20 +590,41 @@ case class FileSourceScanExec(
logInfo(s"Planning scan with bin packing, max size: $maxSplitBytes bytes,
" +
s"open cost is considered as scanning $openCostInBytes bytes.")
+ // Filter files with bucket pruning if possible
+ lazy val bucketingEnabled =
fsRelation.sparkSession.sessionState.conf.bucketingEnabled
Review comment:
> since reading conf is very cheap
That's what I feel too, but I got feedback earlier here -
https://github.com/apache/spark/pull/31413#discussion_r568257272. @maropu -
could you help provide more context here? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
