imback82 commented on a change in pull request #31494:
URL: https://github.com/apache/spark/pull/31494#discussion_r571282171
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -116,7 +116,11 @@ private[sql] object CatalogV2Util {
newProperties.put(set.property, set.value)
case unset: RemoveProperty =>
- newProperties.remove(unset.property)
+ val prop = unset.property
+ if (!unset.ifExists && !properties.containsKey(prop) && prop !=
TableCatalog.PROP_COMMENT) {
Review comment:
This aligns with:
https://github.com/apache/spark/blob/e614f34c7a538b1f2c59616689eaea95af85fd54/sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala#L307-L311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
