cloud-fan commented on a change in pull request #31494:
URL: https://github.com/apache/spark/pull/31494#discussion_r572007541
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java
##########
@@ -64,7 +64,20 @@ static TableChange setProperty(String property, String
value) {
* @return a TableChange for the addition
*/
static TableChange removeProperty(String property) {
Review comment:
Another way is to do the work in Spark analyzer: if the key doesn't
exist and `ifExists = true`, remove this table change.
Then we don't need to change API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
