Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5685#discussion_r29081651
--- Diff:
core/src/test/scala/org/apache/spark/util/ClosureCleanerSuite.scala ---
@@ -50,7 +50,7 @@ class ClosureCleanerSuite extends FunSuite {
val obj = new TestClassWithNesting(1)
assert(obj.run() === 96) // 4 * (1+2+3+4) + 4 * (1+2+3+4) + 16 * 1
}
-
+
--- End diff --
The suite should be expanded with the fix, right? Could you also test the
common `for` loop case that others have seen in the past?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
