Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5685#discussion_r29083093
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -77,6 +80,9 @@ private[spark] object ClosureCleaner extends Logging {
Nil
}
+ /**
+ * Return a list of classes that represent closures enclosed in the
given closure object.
+ */
private def getInnerClasses(obj: AnyRef): List[Class[_]] = {
--- End diff --
Can we do validations here that `obj` is a closure type (for instance doing
an instanceOf check with an exception)? It would add a bit more type safety and
clarity to the API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
