cloud-fan commented on a change in pull request #31273: URL: https://github.com/apache/spark/pull/31273#discussion_r578253558
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ########## @@ -443,33 +443,38 @@ case class InsertIntoDir( } /** - * A container for holding the view description(CatalogTable), and the output of the view. The - * child should be a logical plan parsed from the `CatalogTable.viewText`, should throw an error - * if the `viewText` is not defined. + * A container for holding the view description(CatalogTable) and info whether the view is temporary + * or not. If the view description is available, the child should be a logical plan parsed from the + * `CatalogTable.viewText`. Otherwise, the view is a temporary one created from a dataframe; in this + * case, the child must be already resolved. Review comment: hmm does it really matter? `View.child` is visible to analyzer rules and will be analyzed eventually. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org