cloud-fan commented on a change in pull request #31273:
URL: https://github.com/apache/spark/pull/31273#discussion_r580107291
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -862,7 +862,17 @@ class Analyzer(override val catalogManager: CatalogManager)
}
private def isResolvingView: Boolean =
AnalysisContext.get.catalogAndNamespace.nonEmpty
- private def referredTempViewNames: Seq[Seq[String]] =
AnalysisContext.get.referredTempViewNames
+ private def isReferredTempViewName(nameParts: Seq[String]): Boolean = {
+ AnalysisContext.get.referredTempViewNames.exists { n =>
+ (n.length == nameParts.length) && n.zip(nameParts).forall {
+ case (a, b) => resolver(a, b)
+ }
+ }
+ }
+
+ private def getTempViewRawPlan(plan: LogicalPlan): LogicalPlan = {
+ EliminateDataFrameTempViews(EliminateSubqueryAliases(plan))
Review comment:
`EliminateDataFrameTempViews` doesn't need to be a rule anymore, right?
we can probably just do
```
EliminateSubqueryAliases(plan) match {
case v: View if v.isDataFrameTempView => v.child
case other => other
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
