cloud-fan commented on a change in pull request #31273: URL: https://github.com/apache/spark/pull/31273#discussion_r580111666
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ########## @@ -111,7 +111,7 @@ case class CreateViewCommand( // When creating a permanent view, not allowed to reference temporary objects. // This should be called after `qe.assertAnalyzed()` (i.e., `child` can be resolved) - verifyTemporaryObjectsNotExists(catalog, isTemporary, name, child) + verifyTemporaryObjectsNotExists(catalog, isTemporary, name, analyzedPlan) Review comment: can we remove `L98` to `L101`? It seems we don't need to analyze the plan inside `run` method again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org