sarutak edited a comment on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-783251606
> The API doesn't take Symbol Actually `subquery` and `as` in `dsl/package.scala`, `as` and `alias` in `Dataset.scala`, `as` in `Columnlscala` can take Symbol parameter. We should deprecate them right? `typedlit` in `functions.scala` can take `Symbol` but it's added in Spark `3.2.0` so I think we can just remove the support of `Symbol`. > Does it really work to deprecate an implicit? I haven't confirmed yet but I'll try it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
