cloud-fan commented on a change in pull request #31791:
URL: https://github.com/apache/spark/pull/31791#discussion_r599337436
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -572,6 +603,18 @@ case class Range(
require(step != 0, s"step ($step) cannot be 0")
+ def this(start: Long, end: Long, step: Long, numSlices: Int) =
Review comment:
A function-like `Expression` should have constructors that accept
`Expression` inputs. There are other functions that only take constant as
inputs, but the constructor still takes `Expression`. See `HyperLogLogPlusPlus`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
