cloud-fan commented on a change in pull request #31791:
URL: https://github.com/apache/spark/pull/31791#discussion_r600754594
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -556,11 +557,56 @@ object Range {
val output = StructType(StructField("id", LongType, nullable = false) ::
Nil).toAttributes
new Range(start, end, step, numSlices, output, isStreaming)
}
+
def apply(start: Long, end: Long, step: Long, numSlices: Int): Range = {
Range(start, end, step, Some(numSlices))
}
+
+ private def castAndEval[T](expression: Expression, dataType: DataType): T = {
+ TypeCoercion.implicitCast(expression, dataType)
+ .map(_.eval())
+ .filter(_ != null)
+ .getOrElse {
+ throw
QueryCompilationErrors.incompatibleRangeInputDataTypeError(expression, dataType)
+ }.asInstanceOf[T]
+ }
+
+ def toLong(expression: Expression): Long = castAndEval[Long](expression,
LongType)
+
+ def toInt(expression: Expression): Int = castAndEval[Int](expression,
IntegerType)
}
+@ExpressionDescription(
+ usage = """
+ _FUNC_(start: long, end: long, step: long, numPartitions: integer)
+ _FUNC_(start: long, end: long, step: long)
+ _FUNC_(start: long, end: long)
+ _FUNC_(end: long)""",
+ examples = """
+ Examples:
+ > SELECT * FROM _FUNC_(1);
+ +---+
+ | id|
+ +---+
+ | 0|
+ +---+
+ > SELECT * FROM _FUNC_(0, 2);
+ +---+
+ |id |
+ +---+
+ |0 |
+ |1 |
+ +---+
+ > SELECT _FUNC_(0, 4, 2);
Review comment:
FROM is missing.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -556,11 +557,56 @@ object Range {
val output = StructType(StructField("id", LongType, nullable = false) ::
Nil).toAttributes
new Range(start, end, step, numSlices, output, isStreaming)
}
+
def apply(start: Long, end: Long, step: Long, numSlices: Int): Range = {
Range(start, end, step, Some(numSlices))
}
+
+ private def castAndEval[T](expression: Expression, dataType: DataType): T = {
+ TypeCoercion.implicitCast(expression, dataType)
+ .map(_.eval())
+ .filter(_ != null)
+ .getOrElse {
+ throw
QueryCompilationErrors.incompatibleRangeInputDataTypeError(expression, dataType)
+ }.asInstanceOf[T]
+ }
+
+ def toLong(expression: Expression): Long = castAndEval[Long](expression,
LongType)
+
+ def toInt(expression: Expression): Int = castAndEval[Int](expression,
IntegerType)
}
+@ExpressionDescription(
+ usage = """
+ _FUNC_(start: long, end: long, step: long, numPartitions: integer)
+ _FUNC_(start: long, end: long, step: long)
+ _FUNC_(start: long, end: long)
+ _FUNC_(end: long)""",
+ examples = """
+ Examples:
+ > SELECT * FROM _FUNC_(1);
+ +---+
+ | id|
+ +---+
+ | 0|
+ +---+
+ > SELECT * FROM _FUNC_(0, 2);
+ +---+
+ |id |
+ +---+
+ |0 |
+ |1 |
+ +---+
+ > SELECT _FUNC_(0, 4, 2);
+ +---+
+ |id |
+ +---+
+ |0 |
+ |2 |
+ +---+
+ """,
+ since = "2.0.0",
Review comment:
3.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
