srowen commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r617519509
##########
File path: mllib/pom.xml
##########
@@ -142,20 +142,20 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>lapack</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>arpack</artifactId>
+ </dependency>
+
</dependencies>
- <profiles>
Review comment:
I believe that netlib has two parts, the core Java interface, and a
fuller package including LGPL components. I can work with only the core - falls
back to JVM code. The artifacts behind the profile are the complete "all"
artifact. I think we'd have to follow the same. Anything importing "all" needs
to be behind the profile. You can check the result by running
`dev/test-dependencies.sh --replace-manifest` (which you'll need to do anyway)
to see if the changes in the transitive dependencies have included the "all"
artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
