srowen commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r618448295
##########
File path: mllib-local/pom.xml
##########
@@ -75,48 +75,12 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
+ </dependency>
</dependencies>
- <profiles>
- <profile>
- <id>netlib-lgpl</id>
Review comment:
I believe we'll need the profile in both places - parent is more about
"declaration" and child is more about actually using it.
The diff looks OK, but raises the question, what's in `arpack`, `lapack`,
etc? does that build in native code? I'd have to go check but looks like LAPACK
et al are BSD licensed, which is OK.
But it looks like nothing references the `all` artifact from netlib, so not
sure what would build in the native code to actually do acceleration, even with
the profile? I'm probably missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
