dongjoon-hyun commented on a change in pull request #31876:
URL: https://github.com/apache/spark/pull/31876#discussion_r618068569
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1863,26 +1870,28 @@ private[spark] class DAGScheduler(
// TODO: mark the executor as failed only if there were lots of
fetch failures on it
if (bmAddress != null) {
val externalShuffleServiceEnabled =
env.blockManager.externalShuffleServiceEnabled
- val isHostDecommissioned = taskScheduler
- .getExecutorDecommissionState(bmAddress.executorId)
- .exists(_.workerHost.isDefined)
+ val isHostDecommissioned = execIdOpt.exists { execId =>
+ taskScheduler
+ .getExecutorDecommissionState(execId)
+ .exists(_.workerHost.isDefined)
+ }
- // Shuffle output of all executors on host `bmAddress.host` may be
lost if:
+ // Shuffle output of all executors on host `bmId.host` may be lost
if:
Review comment:
Shall we revert this? In this context, we have `bmAddress` instead of
`bmId`, don't we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
