dongjoon-hyun commented on a change in pull request #31876:
URL: https://github.com/apache/spark/pull/31876#discussion_r618069144
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -2057,11 +2066,15 @@ private[spark] class DAGScheduler(
* reprocessing for follow-on fetch failures)
*/
private def removeExecutorAndUnregisterOutputs(
- execId: String,
+ execIdOpt: Option[String],
fileLost: Boolean,
hostToUnregisterOutputs: Option[String],
maybeEpoch: Option[Long] = None,
ignoreShuffleFileLostEpoch: Boolean = false): Unit = {
+ // This method assumes an executor lost. Thus, it should be no-op for
+ // the storage system whose location isn't based on executors.
Review comment:
Could you revise the function description accordingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
