srowen commented on a change in pull request #32253: URL: https://github.com/apache/spark/pull/32253#discussion_r619357668
########## File path: mllib-local/pom.xml ########## @@ -75,6 +75,11 @@ <type>test-jar</type> <scope>test</scope> </dependency> + + <dependency> + <groupId>dev.ludovic.netlib</groupId> + <artifactId>blas</artifactId> + </dependency> Review comment: I see, so `all` is still needed, and needs to be behind the profile. While not required for license reasons, do any other of your dependencies only makes sense when paired with the `all` artifact, and so should be in the profile too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org