dongjoon-hyun commented on a change in pull request #32515:
URL: https://github.com/apache/spark/pull/32515#discussion_r631171488
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala
##########
@@ -46,16 +46,17 @@ import org.apache.spark.unsafe.types.UTF8String
* Test cases for the [[SparkSessionExtensions]].
*/
class SparkSessionExtensionSuite extends SparkFunSuite {
- type ExtensionsBuilder = SparkSessionExtensions => Unit
- private def create(builder: ExtensionsBuilder): Seq[ExtensionsBuilder] =
Seq(builder)
+ private def create(
+ builder: SparkSessionExtensionsProvider):
Seq[SparkSessionExtensionsProvider] = Seq(builder)
Review comment:
Do we still have all existing test coverage for old code path, @yaooqinn
? Old code path should be protected by a test coverage according to Apache
Spark's recent API management policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
