cloud-fan commented on a change in pull request #32602:
URL: https://github.com/apache/spark/pull/32602#discussion_r637769900



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelation.scala
##########
@@ -137,3 +149,53 @@ object PropagateEmptyRelation extends Rule[LogicalPlan] 
with PredicateHelper wit
     }
   }
 }
+
+/**
+ * Rule [[PropagateEmptyRelationBase]] at normal optimizer side.
+ * With the extra optimal pattern:
+ * 1. Higher-node Logical Plans
+ *    - Union with all empty children.
+ * 2. Unary-node Logical Plans
+ *    - Project/Filter/Sample with all empty children.
+ */
+object PropagateEmptyRelation extends PropagateEmptyRelationBase {
+  private def propagateEmptyRelationBasic: PartialFunction[LogicalPlan, 
LogicalPlan] = {

Review comment:
       nit: `applyFunc`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to