cloud-fan commented on a change in pull request #32602:
URL: https://github.com/apache/spark/pull/32602#discussion_r637849084
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelation.scala
##########
@@ -26,59 +26,48 @@ import org.apache.spark.sql.catalyst.rules._
import org.apache.spark.sql.catalyst.trees.TreePattern.{LOCAL_RELATION,
TRUE_OR_FALSE_LITERAL}
/**
- * Collapse plans consisting empty local relations generated by
[[PruneFilters]].
- * 1. Binary(or Higher)-node Logical Plans
- * - Union with all empty children.
- * - Join with one or two empty children (including Intersect/Except).
- * 2. Unary-node Logical Plans
- * - Project/Filter/Sample/Join/Limit/Repartition with all empty children.
- * - Join with false condition.
- * - Aggregate with all empty children and at least one grouping expression.
- * - Generate(Explode) with all empty children. Others like Hive UDTF may
return results.
+ * The rule used by both normal Optimizer and AQE Optimizer for:
Review comment:
```
The base class of two rules in the normal and AQE Optimizer. It simplifies
query plans with
empty or non-empty relations:
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
