HyukjinKwon commented on a change in pull request #32631: URL: https://github.com/apache/spark/pull/32631#discussion_r640211218
########## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala ########## @@ -115,69 +116,72 @@ abstract class DockerJDBCIntegrationSuite extends SharedSparkSession with Eventu protected var jdbcUrl: String = _ override def beforeAll(): Unit = { Review comment: I would do: ```scala override def beforeAll(): Unit = runIfTestsEnabled(s"Prepare for $this.getClass.getName") { ``` or ```scala override def beforeAll(): Unit = runIfTestsEnabled( s"Prepare for $this.getClass.getName") { ``` to minimise the diff because of the indentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org