sarutak commented on a change in pull request #32631:
URL: https://github.com/apache/spark/pull/32631#discussion_r640250798
##########
File path: dev/run-tests.py
##########
@@ -687,6 +689,10 @@ def main():
test_modules = determine_modules_to_test(changed_modules)
excluded_tags = determine_tags_to_exclude(changed_modules)
+ # With this script, disable docker integration by default.
Review comment:
I didn't intentionally declare it.
If we declare it, `ENABLE_DOCKER_INTEGRATION_TESTS` is always `1`, meaning
docker integration tests always run with `run-tests.py`.
Docker integration tests need Docker and Oracle Docker image installed but
we can't assume all the environment satisfies that.
I'm afraid that If anyone who runs `run-tests.py` on their testing
environment, they fail to do after this change.
At least, Oracle Docker image is absent in the AMPLab Jenkins for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
