Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3913#issuecomment-98068701
Hm, my gut is that it's stranger to put this in the context when it has
nothing to do with the context. It's all private except for the one method.
Lots of accidents can happen but, y'know, that's an argument anywhere.
Something has to commit to at least one name somewhere, yes. What about a
single `object` at this level that exposes a single public method, that calls
into the existing class where it is? I suppose that minimizes the amount that
is surfaced and keeps the implementation alongside other package-private stuff,
at the cost of a little redundancy and extra declaration.
Now it really is down to where to place a single method, and I'd still
argue a little for not tacking it on the context as an uber utility class. This
is a developer API so convenience for the end user isn't a big deal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
